Renovation - Spray foam or Batt Insulation! Advice please!

What climate zone is this project in? This is an important consideration.

Its sounds like you are planning to spray foam the roof structure and make a conditioned attic. This can be a great thing or a very bad thing.

Spray foam applied directly to the underside of the roof sheathing can lead to disaster.