Cicadas

Seems like a poor evolutionary feature. I guess their whole purpose is to make more?

Not really, almost all aquatic insects (all trout food) like mayflies, caddis, stoneflies have a similar life cycle (except they only live as nymphs for 1-2 years)....make more indeed....