Yes, some players look at taxes, or their advisors look at taxes and advise the players. (I know many people on this board refuse to believe that it matters at all, but I bet that some players take that into consideration sometimes.) They also sometimes take into consideration, weather, cost of living in a new city, recreational opportunities, etc., and some look at moving closer to their hometown and family. It is not ALL about the most money for some players. Some players look at the quality of the roster and divisional opponents.
I don't think players make team decisions solely on the basis of state income tax, that would not make sense, but I do think "some" players might consider it along with all of the other factors that go into changing teams and locations. I think some look at housing options also when changing teams and locations, but they don't just look at housing. Some players might look at JUST the absolute most money on a contract and nothing else.